feat(fake-browser): action API in-memory implementation. #101
+291
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklinker1
reviewed
Oct 25, 2025
| const onClicked = | ||
| defineEventWithTrigger<(tab: Tabs.Tab, info: Action.OnClickData | undefined) => void>(); | ||
|
|
||
| let DEFAULT_BADGE_BACKGROUND_COLOR = '#5F5D5B'; |
There was a problem hiding this comment.
These should be const instead of let since they're never reassigned.
| badgeBackgroundColorState.windows.clear(); | ||
|
|
||
| titleState.global = ''; | ||
| titleState.tabs.clear(); |
There was a problem hiding this comment.
We're not resetting the badgeTextColorState. Add:
badgeTextColorState.global = DEFAULT_BADGE_TEXT_COLOR;
badgeTextColorState.tabs.clear();
badgeTextColorState.windows.clear();| const result = await fakeBrowser.action.getBadgeBackgroundColor({ tabId }); | ||
| expect(result).toEqual([0, 255, 0, 255]); | ||
| }); | ||
|
|
There was a problem hiding this comment.
The description says "default black" but #5F5D5B is actually rgb(95, 93, 91) which is a gray color. Update to "should fallback to default gray if color not set" or similar.
Comment on lines
+70
to
+90
| }); | ||
|
|
||
| describe('setBadgeTextColor / getBadgeTextColor', () => { | ||
| it('should set and get global badge text color', async () => { | ||
| const color = '#0000FF'; | ||
| fakeBrowser.action.setBadgeTextColor({ color }); | ||
| //@ts-ignore | ||
| fakeBrowser.action.getBadgeTextColor({}, result => { | ||
| expect(result).toEqual(color); | ||
| }); | ||
| }); | ||
|
|
||
| it('should set and get tab-specific badge text color', async () => { | ||
| const tabId = 123; | ||
| const color = '#00FFFF'; | ||
| fakeBrowser.action.setBadgeTextColor({ tabId, color }); | ||
| //@ts-ignore | ||
| fakeBrowser.action.getBadgeTextColor({ tabId }, result => { | ||
| expect(result).toBe(color); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
What's up with these @ts-ignores? Is it a conflict with @types/webextension-polyfill vs chrome?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being implemented in response to this issue from WXT. wxt-dev/wxt#1569